Reduce the number of warnings in IDEs

Sixdsn / terra-terminal

Terra is a GTK+3.0 based terminal emulator with useful user interface, it also supports multiple terminals with splitting screen horizontally or vertically. New features have been added since September 2013. It's a pretty new and experimental project, if you want to contribute just checkout and try.

GNU General Public License v3.0

7 stars 3 forks source link

Reduce the number of warnings in IDEs #88

Closed SchnWalter closed 9 years ago

SchnWalter commented 9 years ago

I had several hundred warnings in my IDE, this remove a good chunk of them.

Next I'm going to update boolean conditions. But we'll need to check that PR thoroughly because the ConfigManager returns none for missing settings, and there are a lot of configurations that are checked against False. And in python None != False but when used in conditions both are evaluated as False.

Sixdsn commented 9 years ago

Yup i was watching your commits on this PR so it's okay to me as it's only code cleaning and as no impact on indentations that could lead to side effects.

About your next PR on boolean conditions can you open an issue about that and get your commits linked to it?

tanks a lot ;)

SchnWalter commented 9 years ago

I think I finished all the boolean changes, it seems that the None != False issue applies only to code that we already changed in #79

I'll make another review and I'll create a PR once I think it's OK.