Closed GoogleCodeExporter closed 9 years ago
there is some fix i've done to the showfps code in "menu.c", but the same code
is also present in "gnuboy\sys\sdl\sdl.c" Should i submit a patch to the gnuboy
project?
Original comment by hiban1...@gmail.com
on 10 Aug 2011 at 1:07
Here a screenshot of the menu
Original comment by hiban1...@gmail.com
on 10 Aug 2011 at 4:55
Attachments:
Issue 18 has been merged into this issue.
Original comment by clac...@gmail.com
on 11 Aug 2011 at 5:19
Patch changes look good, however there are a number of diffs that show up that
are non-changes. Can you minimize the diffs please? It is possible
carriage_returns and newlines are being added and thus causing the extra diffs.
Ditto for main.c in Issue 18. Can you re-patch with correct new lines (I think
that is the only issue, you can use almost any text editor to do this, e.g.
Scite supports this). You can attach a ding diff for both files to this issue
with "hg diff".
RE gnuboy - no change is needed there, it already works :-) If you build it and
try it you can see (assign a hot key to toggle the fps setting to demo it).
BTW I love the background image and the screen shot is really helpful to show
what the new options looks like.
Original comment by clac...@gmail.com
on 11 Aug 2011 at 5:24
I've edited both patch files. i hope it's all ok now.
Original comment by hiban1...@gmail.com
on 11 Aug 2011 at 7:45
Attachments:
And here is the background image:
Original comment by hiban1...@gmail.com
on 11 Aug 2011 at 9:45
Attachments:
This issue was closed by revision f4ff70c11f20.
Original comment by clac...@gmail.com
on 12 Aug 2011 at 3:47
Perfect patch! Thanks again for all the recent contributions.
Original comment by clac...@gmail.com
on 12 Aug 2011 at 3:49
Original issue reported on code.google.com by
hiban1...@gmail.com
on 10 Aug 2011 at 12:59Attachments: