search

Sixthhokage2 / ohboy

Automatically exported from code.google.com/p/ohboy
GNU General Public License v2.0
0 stars 1 forks source link

Support for BMP Borders in menu. #21

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
This adds a menu option to enable/disable BMP Borders.

There are 2 different borders:
-border1.bmp (for use with no scaling)
-border2.bmp (for use with "sample1.5x" and "scale3x+sample.75x")

Border BMP images go into the "etc" directory. If they don't exist, the border 
is not shown.

Original issue reported on code.google.com by hiban1...@gmail.com on 20 Aug 2011 at 7:13

Attachments:

GoogleCodeExporter commented 9 years ago 
Here is the diff/patch:

NOTE: This requires a small change in the Gnuboy code. I've already submitted a 
patch in the Gnuboy site.

Original comment by hiban1...@gmail.com on 20 Aug 2011 at 7:15

Attachments:

GoogleCodeExporter commented 9 years ago 
Here a couple of templates for the borders, and pics of the borders i use (with 
"DMG" palette)

Original comment by hiban1...@gmail.com on 20 Aug 2011 at 8:09

Attachments:

GoogleCodeExporter commented 9 years ago 
I got the code for BMP support from fishybawb (gp32x.com forums)

Original comment by hiban1...@gmail.com on 20 Aug 2011 at 8:18

GoogleCodeExporter commented 9 years ago 
I'm not clear why NO_SCALE_OFFSET has changed (there is no information and the 
comment no longer reflects the explanation).

Is there an impact on FPS with this patch? I can see code that appears to cause 
a full screen repaint. The comment in the code is unclear.

The patch doesn't apply cleanly (hg rejects it). The checksum/ref for the first 
file doesn't appear in the OhBoy change log.

Do you have a contact address for the person who provided the patch so I can 
follow up with them directly?

Original comment by clac...@gmail.com on 20 Aug 2011 at 10:23

GoogleCodeExporter commented 9 years ago 
i think NO_SCALE_OFFSET changed because it was not really centered.

About impact on FPS, what's the code you refer to? Anyway, you can try yourself 
with the APP attached here.

I did the diff file myself by copy/paste. I know it's a dirty method, maybe 
that's the reason it doesn't apply cleanly...

fishybawb sent me the source code he was working on, and i simply added it to 
mine.
his address is his nickname @gmail dot com.

Original comment by hiban1...@gmail.com on 21 Aug 2011 at 12:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Here are the separate diff files (generated by a program), after cleaning 
everything up. These should work correctly.

Any way of implementing this without changing the gnuboy code?

Original comment by hiban1...@gmail.com on 21 Aug 2011 at 10:40

Attachments:

GoogleCodeExporter commented 9 years ago 
I've sent a mail to the original change author to get provide feedback.

Thanks for attaching clean diffs, these apply without error from hg against 
revision: 57657b7e1cae.

Original comment by clac...@gmail.com on 21 Aug 2011 at 4:21

GoogleCodeExporter commented 9 years ago 
New diffs for main.c and menu.c:

- Updated default buttons for dingoo (A=A, B=B)
- Minor aesthetic changes:
         - Removed "http://ohboy.googlecode.com/" text from menu title (it's already on the "About" section) Now it displays "OHBOY"
         - Removed Gnuboy version from menu statusbar (it's already on the "About" section) Now it displays the menu hints.
         - Moved the "Slide Power to open the menu" to the statusbar (bottom of screen)
         - Added "Press Home to open menu" text for Caanoo in status bar
TODO: add menu hints for Wiz and GP2x (didn´t know which button opens the menu 
in those devices)

Original comment by hiban1...@gmail.com on 21 Aug 2011 at 10:49

Attachments:

GoogleCodeExporter commented 9 years ago 
Here a binary for testing:

Original comment by hiban1...@gmail.com on 21 Aug 2011 at 10:52

Attachments: