Sixthhokage2 / remuco

Automatically exported from code.google.com/p/remuco
1 stars 1 forks source link

Problems with Exaile 0.3.2 #118

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What is your environment?
* OS: Ubuntu 10.04
* Remuco version: 0.9.3
* Client device: midp
* Player: exaile 0.3.2

What steps will reproduce the problem?
1. play file in exaile 0.3.2 with remuco plugin enabled

What is the expected behavior? What happens instead?
Client does not show any tag-information as well as no album artwork is 
displayed. 
It shows just the remuco logo.

Additional information:
With exaile 0.3.1, it works correctly.

Original issue reported on code.google.com by shyam.i...@gmail.com on 12 Aug 2010 at 3:17

GoogleCodeExporter commented 9 years ago
Looks like Exaile's internal API has changed again .. the Exaile guys are 
keeping me busy :/ I'l have a look into it ASAP.

Original comment by obensonne@googlemail.com on 12 Aug 2010 at 6:36

GoogleCodeExporter commented 9 years ago
Oops, that was not ASAP. Does someone has the time and motivation to fix the 
Exaile adpater? 

Original comment by obensonne@googlemail.com on 26 Nov 2010 at 9:11

GoogleCodeExporter commented 9 years ago
Fix attached.

Original comment by ceduardo...@gmail.com on 18 Mar 2011 at 10:00

Attachments:

GoogleCodeExporter commented 9 years ago
thanks 

Original comment by shyam.i...@gmail.com on 19 Mar 2011 at 12:51

GoogleCodeExporter commented 9 years ago
Does this patch also still support Exaile 3.1? It should do so, as e.g. Ubuntu 
10.04, which is a long term support version, still ships this version. I think 
support for Exaile 3.0 is not necessary anymore. Also, your patch looks like a 
reversed one.

Could you please check this and then provide a new patch created with the 
'diff' command using the '-u' option -> '$ diff -u orig edit'? Thanks!

Ah, and if you want your credits to be seen in the source control history, 
please give me a name and email to commmit under.

Original comment by obensonne@googlemail.com on 21 Mar 2011 at 7:01

GoogleCodeExporter commented 9 years ago
Concerning the Totem problem, feel free to create a new issue and attach your 
patch there. Thanks!

Original comment by obensonne@googlemail.com on 21 Mar 2011 at 7:03

GoogleCodeExporter commented 9 years ago

Original comment by obensonne@googlemail.com on 21 Mar 2011 at 7:04

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Hi, Oben. Here is the patch generated with the parameters you specified. I 
don't have much experience with this tool, hence the misgenerated patch. :)

I've tested the patch under exaile 0.3.1.2, and it must run with other versions 
as well. Exaile 0.3.2 changed the cover API. I only created a flow control (in 
the __update_track function) and imported the new cover API.

This way, the plugin still works with all the previously working versions, plus 
0.3.2.

Oh, if licensing is a concern, I give the property of this patch to the remuco 
team. You can use this e-mail address to put at the commit (Carlos Eduardo Melo 
<ceduardo.melo at gmail dot com>)

Best regards!

Original comment by ceduardo...@gmail.com on 21 Mar 2011 at 9:52

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 7ce7b88da0c0.

Original comment by obensonne@googlemail.com on 22 Mar 2011 at 8:35

GoogleCodeExporter commented 9 years ago
Thanks, C. Eduardo!

Original comment by obensonne@googlemail.com on 22 Mar 2011 at 8:44

GoogleCodeExporter commented 9 years ago

Original comment by obensonne@googlemail.com on 22 Mar 2011 at 8:44