search

Sixze / ALS-Refactored

Completely reworked and improved C++ version of Advanced Locomotion System V4.
MIT License
978 stars 273 forks source link

Issues with camera clipping in to geometry / objects, game breaking for many types of games. #428

Closed xkamronx closed 6 months ago

xkamronx commented 10 months ago

Long story short - the camera being on the head bone allows the camera to clip through geo on basically any object fairly easily. The easiest method being crouching and looking straight at the ground while as close as possible to a mesh - the camera will clip through the geometry.

It is possible to partially remedy the issue by increasing the character's capsule size, but as noted in a previous interaction with you - I shouldn't be changing the capsule size as it doesn't interact / update the vaulting/mantling traces, so you can vault through areas you can't fall through.

Even with a larger capsule, the impulse on sprint can very easily also clip the character's head through a wall. In some instances, it's possible to get the camera through other objects like stairs / ramps by being underneath it, even in third person.

This can be pretty game breaking, where many games that have interaction can interact with objects through walls, ceilings, etc. I'm in the process of implementing additional checks, but I feel the general issue applies to all projects using Refactored, as the camera clipping in to geometry likely isn't a wanted feature in the vast majority of games.

Mellnik commented 10 months ago

I also noticed that camera clipping in first person is pretty much a deal breaker. I've tried improving it but I don't think I've fixed the source reason 🤷

It would also be great to have an option to make the camera more "static". For example when you turn 180° while standing, the character turns around and the camera makes some weird movement which comes from the character's body movement. It's pretty annoying to play with.

colorindarkness commented 9 months ago

Have you tried adjusting the Camera Settings Data Asset? image

xkamronx commented 8 months ago

Have you tried adjusting the Camera Settings Data Asset? image

Yep, there's not a end all be all fix with any settings configuration I have tested yet.

xkamronx commented 8 months ago

I also noticed that camera clipping in first person is pretty much a deal breaker. I've tried improving it but I don't think I've fixed the source reason 🤷

It would also be great to have an option to make the camera more "static". For example when you turn 180° while standing, the character turns around and the camera makes some weird movement which comes from the character's body movement. It's pretty annoying to play with.

I haven't noticed much annoyance with the system overall but I do have a few of the built in movement features removed for users who said it was giving them motion sickness.

The camera clipping is a huge deal to me though. I increased the player's capsule size which I was told previously not to do because it messes with the vaulting trace, but it didn't seem like I had much of a choice for a somewhat close / simple fix to the camera being able to clip through walls basically on command.