search

Sizzzles / TFT-OCR-BOT

TFT OCR Bot with auto comps loading from lolchess
GNU General Public License v3.0
18 stars 2 forks source link

adds non valid champ #6

Closed garbagexbag closed 1 year ago

garbagexbag commented 1 year ago

on round between 1-2 and 1-4 included the bot thinks it adds an unknown champ to the board while it actually adds nothing, which leads to it thinking for major part of the game it has one more champ on the board than it actually does. this does not seem to happen on the main branch this was forked from

Sizzzles commented 1 year ago

I've never had this issue. But increased sleep between clicks for unknown champions. Let me know if it fixes the issue

garbagexbag commented 1 year ago

Yeah seems like that fixed it, don't know how or why this could cause an issue though so this could be closed.

On another note the problem with this bot is the builds don't come alive past mid game when the player is already way below half health due to the bot not picking anything optimal besides what the build recommends. I think one of the ways to greatly improve this without too much effort would be to either specify champs/comps pre final build or for the bot to grab top tier champs from a site like tftactics.gg and use them until it finishes the build. Currently I don't even understand the logic of it buying champs to fill up slots should it not have champs needed for the final comp. For example this isn't an issue on the main branch because you can specify low tier but still good filler champs, mark them as not being in the final build and have them equipped with the same items the bot finally tries to build onto the final comp. But yeah just an idea for you as you are someone who is working on this.

Sizzzles commented 1 year ago

Okay perfect.

I know what you mean and completely understand. I would love to fix this since I've noticed the same thing and have been frustrated with it but the main problem would be making sure it sells the champion the right champion especially if it's being used to hold items for a champion in the comp. I can see problems since it's pulling the latest comps from a site so having static fillers champs would be a problem for the 'dynamic' comps. I also don't have as much free time as I once did so it's hard for me to implement new logic like this.... But hopefully it can be worked on in the future.