Sjeiti / TinySort

TinySort is a small script that sorts HTML elements. It sorts by text- or attribute value, or by that of one of it's children.
http://tinysort.sjeiti.com/
MIT License
455 stars 68 forks source link

dist/tinysort.charorder.min.js has a variable use before initialization #174

Open krugar opened 3 years ago

krugar commented 3 years ago

The current version of tinysort.charorder.min.js causes the following TypeError (in Firefox 88.0):

Uncaught TypeError: j is undefined (tinysort.charorder.min.js:1:206)

The way I understand this is that Webpack moves the const declaration/initialization of allCharList into a var declaration/initialization below the function definition of prepare, in the assumption that the declaration is hoisted and everything should work. But JavaScript only hoists the declaration of the variable, not the initialization, which means that when allCharList.slice(0) is called, the variable exists, but is not yet initialized, resulting in the "is undefined" error above.

I don't quite know how to tell Webpack to not make this mistake (or whether newer versions of Webpack don't do this), but I'd assume separating declaration and initialization into distinct statements would work.

Sjeiti commented 3 years ago

Thanks for the find. I'll try to have a look at it this week. One would think with const and let the days of having to deal with hoisting would be behind us.