Add missing architectures, change deployment target to iOS 10

Sjors / libwally-swift

Swift wrapper for LibWally, a collection of useful primitives for cryptocurrency wallets

MIT License

40 stars 18 forks source link

Closed jackpooleybc closed 5 years ago

jackpooleybc commented 5 years ago

This PR mainly fixes two issues:

It changes the Deployment Target to iOS 10.0, and the Swift language version Swift 5 in the podspec
It adds missing architectures to the libwally-core build script

Sjors commented 5 years ago

iOs 10 indeed still supports the 32 bit A6 chip. This should be tested on an iPhone 5(C). See https://i.stack.imgur.com/jKZE4.png

Why are you dropping -fembed-bitcode? (I have no idea what it does)

Sjors commented 5 years ago

Can you drop a29fe5b2a1e3bc53ba325e5152bd39ff1f2547bd? I merged it from #12 because that also updated the README.

jackpooleybc commented 5 years ago

@Sjors done

Sjors commented 5 years ago

With the commands:

git config githubmerge.repository blockchain/libwally-swift
../bitcoin-maintainer-tools/github-merge.py 11

I had to make a small tweak to the merge script to handle the submodule, so it might be incorrect...