search

Sjors / libwally-swift

Swift wrapper for LibWally, a collection of useful primitives for cryptocurrency wallets
MIT License
40 stars 18 forks source link

Update BIP32.swift to make `privKey` public. #39

Closed Fonta1n3 closed 3 years ago

Fonta1n3 commented 4 years ago

In order to use individual child keys to sign a PSBT or raw transaction we need to be able to access privKey. Considering the xprv property is public it does not seem to do any harm to expose a child key. Signing single sig psbt's with anything but the root xprv does not seem to work. I would like to solve that issue but in order to do that I need to be able to access child private keys. Generally speaking it would be nice to access child private keys to sign transactions with irregardless.

ChristopherA commented 4 years ago

+1 to making the xprv public.

Sjors commented 4 years ago

Ah yes, the xpriv cat is already out of the bag.

utACK e1dbb7d1eb3692d9339148ea06eec58353bc5630

Sjors commented 3 years ago

Thanks, merged via the web interface because the original branch seems to have disappeared.