search

Sjors / libwally-swift

Swift wrapper for LibWally, a collection of useful primitives for cryptocurrency wallets
MIT License
40 stars 18 forks source link

Switch to vanilla libsecp256k1 #54

Closed Sjors closed 2 years ago

Sjors commented 2 years ago

Libwally includes libsecp256k1-zkp as a submodule, because it has support for cryptographic functions used in Elements.

This PR swaps out the submodule with vanilla libsecp256k1 which is used by Bitcoin Core. It also uses the same version.

Sjors commented 2 years ago

Bump commit if https://github.com/bitcoin/bitcoin/pull/23383 lands.

Sjors commented 2 years ago

Rebased now that libwally-core 0.8.5 is out. Also bumped to the latest commit that Bitcoin Core uses.

One downside of this approach is that it leaves the libwally-core submodule dirty after each build. @jurvis thoughts?

jurvis commented 2 years ago

@Sjors no strong opinion either way 😄