search

Sjors / libwally-swift

Swift wrapper for LibWally, a collection of useful primitives for cryptocurrency wallets
MIT License
40 stars 18 forks source link

Avoid spurious rebuilding of libwally-core #80

Closed Sjors closed 1 year ago

Sjors commented 1 year ago

It currently rebuilds all of libwally-core every time I run a test.

Sjors commented 1 year ago

cc @jurvis any idea why that's happening?

jurvis commented 1 year ago

Ah, yes. I think the current custom build step doesn't check if the static library is already generated, and hence tries to build it every time. I'll submit a PR today or tomorrow to fix this

jurvis commented 1 year ago

I added changes to what you already have in 2022/11/wally-core-0.8.6 and opened #82. Let me know if it works with your workflow for nthKey?

I need to clean up a pre-build script in the scheme, but I'll do it once you can confirm the solution works.

Sjors commented 1 year ago

This works great.