search

Sjors / libwally-swift

Swift wrapper for LibWally, a collection of useful primitives for cryptocurrency wallets
MIT License
40 stars 18 forks source link

Don't rebuild C static libs if the desired architecture/platform already exists #82

Closed jurvis closed 1 year ago

Sjors commented 1 year ago

Works great. I tested that it doesn't needlessly build libwally-core. I can now run individual tests (quickly). Cleaning the build folder doesn't trigger a rebuild either, which is a bit odd. But a git clean -dfx inside CLibWally/libwally-core does cause a rebuild.

Sjors commented 1 year ago

Let me know if it works with your workflow for nthKey?

I assume this won't really impact pod install would it?

jurvis commented 1 year ago

Cleaning the build folder doesn't trigger a rebuild either, which is a bit odd.

Yeah, this is unfortunately the result of custom build targets not being able to access and customize clean operations, as described here: https://github.com/Sjors/libwally-swift/pull/82#discussion_r1032663344

I assume this won't really impact pod install would it?

I don't suppose so, pod install basically runs the same build steps as what CI does in this job: https://github.com/Sjors/libwally-swift/actions/runs/3550319288/jobs/5963588666. If that works, pod install shouldn't have any issues.

Sjors commented 1 year ago

Merged in fa1ce0079677a58c805a02f71e185f6a2f49b07d.