Fix mnemonic entry - Githubissues

Sjors / nthkey-ios

Your iOs device in a Bitcoin multi-sig

https://nthkey.com

MIT License

17 stars 7 forks source link

Fix mnemonic entry #41

Closed w-i-n-s closed 3 years ago

w-i-n-s commented 3 years ago

This pull request contains:

work with a mnemonic move to separate view
mnemonic validation task moved to model from view
add suggestions for entering words (used https://github.com/bitcoin/bips/blob/master/bip-0039/english.txt as recommended in #27 )

resolve #27

Sjors commented 3 years ago

Nice! Unfortunately the OK button no longer works for me:

Can you also squash f85e6dc into 4cb53b4786ff0b3a9ef05b3cbfd5caf0f16abdd5?

I cherry-picked 850446578286b9216fccad08f5d86466a1e5cb9d into master, so you can leave the first commit out when you rebase.

Sjors commented 3 years ago

I think it did store the mnemonic though, because when I restart the app on master it knows the mnemonic.

w-i-n-s commented 3 years ago

@Sjors

I think it did store the mnemonic though, because when I restart the app on master it knows the mnemonic.

Yes, just wrong use of SeedManager structure as container of the hasSeed flag. I refactor it and it should work after 7aed76b0b2354771028b2e9c225eeed55aa33b12

w-i-n-s commented 3 years ago

@Sjors

Can you also squash ... so you can leave the first commit out when you rebase.

I did rebase all branch according to master. Hope it looks okay.