Sjouwer / pick-block-pro

An advanced client side Block, Entity, NBT, Tool and ID picker for minecraft
https://modrinth.com/mod/pick-block-pro
GNU Lesser General Public License v3.0
9 stars 5 forks source link

Fix and update ru_ru.json #13

Closed Felix14-v2 closed 1 year ago

Felix14-v2 commented 1 year ago

Important

The names of the paintings won't be translated due to Mojang's decision (they updated their glossary), so i would recommend you just to hardcode their names and remove them from the translation files to avoid unintentional inconsistency image

Sjouwer commented 1 year ago

Thanks a lot! Also, my bad, I should have checked if the json syntax was valid. I'll make sure to do that in the future.

Sjouwer commented 1 year ago

Oh and I'll also take a look at the painting names, I saw they added them in the creative menu in the latest 1.19.4 snapshot, so I'll see if I can use those when picking paintings, so the name and artist will already be correct

Sjouwer commented 1 year ago

Painting names redone :) https://github.com/Sjouwer/pick-block-pro/commit/38a7dc46dbc14d0e9bec0b1afa8576862f99e129

Felix14-v2 commented 1 year ago

Painting names redone :) 38a7dc4

Noooo... I was too slow to tell you — Mojang has changed their policy regarding the translation of the paintings :D This happens extremely rarely, but we seem to be lucky. Now the pictures have been removed from the list of untranslatable terms. Anyway, at the moment there are no officially accepted translations yet, although by the release of 1.19.4 the proofreaders will have to approve them.

Sjouwer commented 1 year ago

Ah ty for the update. Good thing I'm using the new official translation keys for the paintings, so it should all work out fine