search

Sk1erLLC / HypixelNetWorth

MIT License
1 stars 2 forks source link

Naming of entries #2

Open solonovamax opened 4 years ago

solonovamax commented 4 years ago

Are the names of these cosmetics directly tied to the names provided by some API? If not, it is unclear how some cosmetics would be named.

In some shops like the bedwars shop, there are categories like "Projectile Trails", "Victory Dances", "Final Kill Effects", etc. Should a cosmetic like the "Smash" final kill effect be named stats.Bedwars.smash or stats.Bedwars.finalkill.smash? If you go with the first option, there are some names that would conflict like the "Firework" final kill effect and the "Firework" projectile trail, as both would end up being called stats.Bedwars.firework.

solonovamax commented 4 years ago

I propose a naming scheme like this: All entries for each type are named beginning with stats, followed by the name of the game, followed by the category the entry belongs to in the hypixel shop menu (If it is a part of 2 categories like "Kits & Perks" and "Normal Kits" for the Armorer kit in skywars, only use the most relevant category. It would be "Normal Kits" in this case.), finally followed by the name of the entry. (everything is lower case) Here are some examples: stats.hungergames.advancedkits.astronaut (unsure why you used "HungerGames" instead of "BlitzSG", so I'm leaving that.), stats.skywars.normalkits.armorer, stats.bedwars.victorydances.dragonrider.