Sk1erLLC / Hytilities

Hypixel-focused Quality of Life mod.
GNU General Public License v3.0
52 stars 20 forks source link

Locraw outputs still are shown in the ReplayMod studio #86

Open ChachyDev opened 3 years ago

ChachyDev commented 3 years ago

Image of bug

None. Example output however:

{"server":"mini250J","gametype":"BEDWARS","mode":"BEDWARS_EIGHT_TWO","map":"Lightstone"}

Description

When using the ReplayMod ("RM") studio the locraw output is still shown. This is most likely because we only cancel the locraw message when the Player is active on Hypixel but not if they were in the RM studio...

How to reproduce?

  1. Load the game with Hytilities & RM
  2. Join the Hypixel Server mc.hypixel.net
  3. Use the mod for a decent amount of time, locraw should've been used once or twice by then
  4. Disconnect from Hypixel and go into Replay Videos
  5. Choose your latest Replay video
  6. Watch the replay and locraw messages appear in chat

Possible solutions

Unsupported solutions

ghost commented 3 years ago

Johni suggests using !mc.isSingleplayer() && mc.getCurrentServerEntry() == null && !mc.isConnectedToRealms() to detect if it's a Replay world or not

Wyvest commented 3 years ago

In my experience, Hytils Locraw just sometimes shows the output of locraw and sometimes doesn't