search

Sk1erLLC / Patcher

A Forge mod full of Vanilla bug fixes, Quality of Life improvements, and performance enhancements.
Other
232 stars 60 forks source link

Improvement Suggestion #124

Closed TripleCF closed 1 year ago

TripleCF commented 2 years ago

Wouldn't it make more sense and save resources to add a if statement to 'BlockNetherWartMixin_CropHeight.java' which checks wether the block is a nether wart?

if(worldIn.getBlockState(pos).getBlock() == Blocks.nether_wart){ CropUtilities.updateWartMaxY(worldIn, pos, worldIn.getBlockState(pos).getBlock()); }

Would save the client from calling the updateWartMaxY function every time.

ghost commented 1 year ago

Yes! You can also make a pull request and get it fixed manually

Sychic commented 1 year ago

It's already only nether wart blocks.

ghost commented 1 year ago

Ok.