search

Sk1erLLC / Patcher

A Forge mod full of Vanilla bug fixes, Quality of Life improvements, and performance enhancements.
Other
232 stars 60 forks source link

HUD Caching not rendering the vignette #165

Open Alexdoru opened 11 months ago

Alexdoru commented 11 months ago

There is a mixin canceling the vignette render but it's not rendering the vignette when rendering the cached frame

Sychic commented 4 months ago

Are you sure about this? From what I can tell, the vignette is rendered via vanilla code when GuiIngame#renderGameOverlay is called.

Alexdoru commented 4 months ago

Yes I am sure and to test this you can do the following : In vanilla minecraft the game will render a vignette when you are close to a world border so you can go in a survival world and use the vanilla command /worldborder set 10 to create a worldborder and if HUD caching is OFF it will correctly render the vignette but when you turn it ON it disappears.

This commit (https://github.com/GTNewHorizons/Angelica/commit/32e2efc1e530dfded0d2f6bf4cfde63e436a9ade) supposedly fixes this issue in the 1.7.10 backport of HUD caching.