Skalar / google_distance_matrix

Ruby client for The Google Distance Matrix API.
MIT License
58 stars 45 forks source link

make https default and adjust tests #15

Closed w8m8 closed 8 years ago

w8m8 commented 8 years ago

Suggestion, with a push request to make the protocol be https by default. From what I see now there are no restrictions to having https be the default.

Currently if a person wants to add an API key to google_distance_matrix it will be refused, as it requires an https connection with an API key enabled. Thus I think it will remove a barrier of entry for new users of the gem as-well, as there is currently no documentation on how to change the protocol to https.

thhermansen commented 8 years ago

Hi,

This looks good, thank you!

I think I fixed the failing travis ci in master with pull request #16. Do you mind merging master in to your branch and push it so we trigger a new ci run?