thhermansen
commented
8 years ago I agree that would be great. Feel free to see if you can implement it and submit a pull request. Remember to write rspec tests for your submitted code.
I think a good way to do it is to have one class handle the conversion between lat/lng to encoded polylines. Then let Place#to_param use that class to return it's lat/lng values encoded instead of lat/lng numeric value.
Place#to_param already receives options from UrlBuilder#params and the UrlBuilder has access to the configuration object so we can add one option to the config to let users either use encoded values or the old lat/lng values like we have it today.
Edit: Maybe a better approach is to let the UrlBuilder take all places and encode them in to one encoded polyline to save characters in the URL. The API doc states that you can have multiple enc: separated by the pipe character in origins/destinations, but maybe it is better to simply encode them all in to one polyline?
Suggestions for todos
- [x] Implement a class which knows how to encode a set of Places.
- [x] Add a configuration option to let user control if we should use encoded polyline or not.
- [x]
UrlBuilderreads from config to see if it should use encoded polyline. If so, find all places we can encode (has lat/lng, not address) and use them to build encoded origins and destinations with our encoding class. Take the rest we cannot encode and add them too.
kofronpi
It would be great if the
google_distance_matrixwould support encoded polylines as request parameters, which allow to query for more locations in a single API call:https://developers.google.com/maps/documentation/distance-matrix/intro#RequestParameters