search

Skallwar / GSL1680

Arduino driver for GSL1680 - For anthology, this is my first real piece of code
Apache License 2.0
12 stars 4 forks source link

Misplaced delays #6

Open Bornock opened 3 years ago

Bornock commented 3 years ago

In the two routines void GSL1680::clear_reg() and void GSL1680::reset() the < delay(TIMER[i]); > should be placed outside of the for...loop after the < int r = Wire.endTransmission(); >

With the delay inside the loop it introduces extra delays onto the I2C bus timings that cause unwanted errors 3 or 4. The GSL1680 uses these delays to actually execute the clear and/or reset.

Skallwar commented 3 years ago

As far as I can understand, the linux kernel seem to do the same as I am currently doing: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/input/touchscreen/silead.c#n244

Maybe I did not understand what you are saying. Feel free to open a PR, so we can discus this over some code ;)