Skallwar / suckit

Suck the InTernet
Apache License 2.0
733 stars 38 forks source link

Minimum Supported Rust Version (MSRV) #130

Closed pinkforest closed 3 years ago

pinkforest commented 3 years ago

Rust has RFC open for MSRV: https://github.com/rust-lang/rust/issues/65262

Cargo has added it: https://github.com/rust-lang/cargo/pull/8037

I test MSRV as part of my CI: https://github.com/pinkforest/gis_puller/blob/main/.github/workflows/CI.yml

I have multiple toolchains so I just usually run & test with +toolchain to figure this out.

Badge is available from shields.io - e.g. 1.47.0: ![MSRV](https://img.shields.io/badge/MSRV-1.47.0-blue)

Skallwar commented 3 years ago

I'm running foresterre/cargo-msrv. I will report the results tomorrow

Skallwar commented 3 years ago

The MSRV is: 1.46.0

pinkforest commented 3 years ago

Cool!

I would additionally eventually recommend setting in README/documentation:

Not too bothered usually but for heavily used libraries it might make sense eventually (hello enterprise world)