search

Skallwar / suckit

Suck the InTernet
Apache License 2.0
735 stars 38 forks source link

Incorrect local URLs on an index_no_slash.html #181

Open raphCode opened 2 years ago

raphCode commented 2 years ago

When the URL does not end with an slash, the downloaded file becomes index_no_slash.html. But the converted local links are wrong, because url.join() is called, and since the URL does not end with an slash, it strips away the last folder, thinking it is a file.

I made a hackish fix here: https://github.com/raphCode/suckit/tree/hack_url_fix Not sure if you want to merge, feel like a mess.

star2202 commented 2 years ago

@raphCode hey bro I am getting an Downloader.get() has encountered an error: still got the same error with your variant as well any idea how can I fix this it's sort of confusing for my little no coding knowledge brain image

Skallwar commented 2 years ago

Put a '/' after '.com', it should fix this.

Sorry for the delay in a lot of fixes and issues, I don't have a lot of free time these days