search

Skallwar / suckit

Suck the InTernet
Apache License 2.0
728 stars 40 forks source link

ci: Check with `--locked` flag #193

Closed orhun closed 2 years ago

orhun commented 2 years ago

This makes it possible to detect issues like #192 earlier in the continuous integration process.

Skallwar commented 2 years ago

While we are at it, why not put this at every stage?

orhun commented 2 years ago

While we are at it, why not put this at every stage?

Do you mean cargo build here:

https://github.com/Skallwar/suckit/blob/32aa47aa645d88f5954cdae813542003890775b3/.github/workflows/build_and_test.yml#L78

I can add it build command as well but check will already fail before reaching there.

Skallwar commented 2 years ago

Let's add it in build this way if the ci changes a bit and check is not before build for some reason, we will not have issues While you are at it, could you rebase your branch instead of having a merge commit :)