search

SkalskiP / make-sense

Free to use online tool for labelling photos. https://makesense.ai
GNU General Public License v3.0
3.05k stars 496 forks source link

Bounding boxes drawing cancels when drawing over the edge of an image #10

Closed tobsecret closed 4 years ago

tobsecret commented 4 years ago

Expected behaviour

When drawing a bounding box or other marker over the edge of an image, anything drawn over the edge clips to the edge.

Observed behaviour

When drawing a bounding box over the edge of an image, the drawing cancels. This makes it more difficult to label objects in the periphery of images, which is frequently where they will be in microscopy images.

SkalskiP commented 4 years ago

@tobsecret Today I am starting to develop on this issue. I'll keep you posted on the progress.

tobsecret commented 4 years ago

Awesome, thank you!

SkalskiP commented 4 years ago

@tobsecret Snapping rectangles and points to the edges of the photo is now available in the developer version. If you have time to see the results of the work, you can test them on: https://develop.d2e9l8xwkaodsq.amplifyapp.com/

tobsecret commented 4 years ago

That looks awesome! Just how I thought it should be :ok_hand: When you make the polygon, it would also make sense for a newly drawn point to snap to the edges if drawn over the edge.

SkalskiP commented 4 years ago

Thanks, too, I think the new behavior is much better than the existing one. It is incomparable! That is my plan - to maintain consistent behaviour for all types of labels. Polygon will be the most complicated so far, but I will try my best.