search

SkalskiP / make-sense

Free to use online tool for labelling photos. https://makesense.ai
GNU General Public License v3.0
3.16k stars 525 forks source link

Next/Prev shortcut doesn't work from left panel #212

Open scottamain opened 3 years ago

scottamain commented 3 years ago

Describe the bug The next/previous keyboard shortcut only works when the browser focus is on the image.

To Reproduce Steps to reproduce the behavior:

  1. Open several images for object detection annotation
  2. Click an image in the left panel
  3. Press OPTION+RIGHT (on Mac) to navigate to next

Expected behavior Navigates to next. But nothing happens. I must click on the large image view and only then the key command works.

Desktop (please complete the following information):

github-actions[bot] commented 3 years ago

👋 Hello @scottamain, thank you for your interest in make-sense - free to use online tool for labelling photos! 🏷️

🐞 Bug reports

If you noticed that make-sense is not working properly, please provide us with as much information as possible. To make your life easier, we have prepared a bug report template containing all the relevant details. We know, we ask for a lot... However, please believe that knowing all that extra information - like the type of browser you use or the version of node you have installed - really helps us to solve your problems faster and more efficiently. 😉

💬 Get in touch

If you've been trying to contact us but for some reason we haven't responded to your issue yet, don't hesitate to get back to us on Gitter or Twitter.

💻 Local setup

# clone repository
git clone https://github.com/SkalskiP/make-sense.git

# navigate to main dir
cd make-sense

# install dependencies
npm install

# serve with hot reload at localhost:3000
npm start

To ensure proper functionality of the application locally, an npm 6.x.x and node.js v12.x.x versions are required. More information about this problem is available in the #16 issue.

SkalskiP commented 3 years ago

Hello @scottamain 👋. ! Thank you for bringing that issue to my attention. We'll try to fix that issue as soon as possible.

SkalskiP commented 3 years ago

I changed the label of that task from but to new-feature as right now we do not support any shortcuts in the left and right panels.

mitch-karch commented 3 years ago

+1 This would make labelling much faster from the right panel (cycle to next photo, hit which label, repeat)

SkalskiP commented 3 years ago

@mitch-karch and @scottamain I already started to work on that task :)