SkalskiP / make-sense

Free to use online tool for labelling photos. https://makesense.ai
GNU General Public License v3.0
3.1k stars 509 forks source link

If a label is too long, delete button is hidden. #303

Open a-fly-fly-bird opened 1 year ago

a-fly-fly-bird commented 1 year ago
image

As you can see, it's hidden. I can not delete my annotation.

github-actions[bot] commented 1 year ago

👋 Hello @a-fly-fly-bird, thank you for your interest in make-sense - free to use online tool for labelling photos! 🏷️

🐞 Bug reports

If you noticed that make-sense is not working properly, please provide us with as much information as possible. To make your life easier, we have prepared a bug report template containing all the relevant details. We know, we ask for a lot... However, please believe that knowing all that extra information - like the type of browser you use or the version of node you have installed - really helps us to solve your problems faster and more efficiently. 😉

💬 Get in touch

If you've been trying to contact us but for some reason we haven't responded to your issue yet, don't hesitate to get back to us on Gitter or Twitter.

💻 Local setup

# clone repository
git clone https://github.com/SkalskiP/make-sense.git

# navigate to main dir
cd make-sense

# install dependencies
npm install

# serve with hot reload at localhost:3000
npm start

To ensure proper functionality of the application locally, an npm 8.x.x and node.js v16.x.x versions are required. More information about this problem is available in the #16 issue.

SkalskiP commented 1 year ago

Hi, @a-fly-fly-bird! Thanks for reporting that bug! It looks like it is not visible when the currently selected label name is too long. Let me take a look at it and work on some fixes.

a-fly-fly-bird commented 1 year ago

Thanks for your work.

From: Piotr Skalski @.> Date: Tuesday, December 27, 2022 at 21:16 To: SkalskiP/make-sense @.> Cc: Lucas Tan @.>, Mention @.> Subject: Re: [SkalskiP/make-sense] If a label is too long, delete button is hidden. (Issue #303)

Hi, @a-fly-fly-birdhttps://github.com/a-fly-fly-bird! Thanks for reporting that bug! It looks like it is not visible when the currently selected label name is too long. Let me take a look at it and work on some fixes.

— Reply to this email directly, view it on GitHubhttps://github.com/SkalskiP/make-sense/issues/303#issuecomment-1365894701, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ2752KCMTHKIS2Z5RVRVTLWPLTZXANCNFSM6AAAAAATKEM7JA. You are receiving this because you were mentioned.Message ID: @.***>

SkalskiP commented 1 year ago

@a-fly-fly-bird I just merged https://github.com/SkalskiP/make-sense/pull/304 into the develop branch. Please take a look and let me know if it works for you.

Note Until the next release - 1.12.0-alpha, new changes won't be accessible at https://makesense.ai, but only on MS development version at https://develop.makesense.ai.

SkalskiP commented 1 year ago

@a-fly-fly-bird did you had time to test the fix?

a-fly-fly-bird commented 1 year ago

@a-fly-fly-bird did you had time to test the fix?

Yeah, I run it locally, and it seems that the excess part will become three points.

image
SkalskiP commented 1 year ago

Grat! I'm closing the issue :)