Skarsnik / QUsb2snes

A Qt based webserver for usb2snes. Users: go check usb2snes.com
https://skarsnik.github.io/QUsb2snes/
GNU General Public License v3.0
52 stars 33 forks source link

Cannot compile due to missing header file #112

Closed cout closed 2 years ago

cout commented 2 years ago

I cannot compile master nor v0.7.22 due to this error:

g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DGIT_TAG_VERSION=\"v0.7.22\" -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_WEBSOCKETS_LIB -DQT_NETWORK_LIB -DQT_SERIALPORT_LIB -DQT_CORE_LIB -I. -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtWebSockets -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtSerialPort -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o appui.o appui.cpp
In file included from devices/emunetworkaccessfactory.h:26,
                 from appui.h:28,
                 from appui.cpp:44:
devices/emunetworkaccessdevice.h:29:10: fatal error: emunwaccessclient.h: No such file or directory
   29 | #include "emunwaccessclient.h"
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:731: appui.o] Error 1

Where can I find emunwaccessclient.h?

black-sliver commented 2 years ago

emunwaccess is a submodule. You'll have to pull that, e.g. using git submodule update --init --recursive.

@Skarsnik maybe we want to add a "full source" distribution (.tar.gz) to Releases -> Assets for future releases.

cout commented 2 years ago

I see, I already had EmuNWAccess-qt under the top-level directory, but now the build scripts expect it under devices/EmuNWAccess-qt. I'm not sure how I got it into that state, but it builds successfully now.

In my defense, I did consider that it might be a submodule, but upon re-reading COMPILING.adoc, I thought "no, if QUsb2snes were using submodules, it would have been mentioned here". So it might be worth adding something there for clarity.