search

Skarsnik / QUsb2snes

A Qt based webserver for usb2snes. Users: go check usb2snes.com
https://skarsnik.github.io/QUsb2snes/
GNU General Public License v3.0
52 stars 33 forks source link

Deduplicate submodule #128

Closed IslandUsurper closed 3 months ago

IslandUsurper commented 3 months ago

When I package QUsb2snes for my NixOS system, it throws an error in the fetch-sources step because of the submodules.

# ---8<--- normal git-checkout output ---8<---
From https://github.com/Skarsnik/QUsb2snes
 * tag               v0.7.28    -> FETCH_HEAD
Switched to a new branch 'fetchgit'
Submodule 'devices/EmuNWAccess-qt' (https://github.com/black-sliver/EmuNWAccess-qt.git) registered for path 'device>
Submodule 'extras/SNESClassicMemoryFinder/snesclassicstuff' (https://github.com/Skarsnik/snesclassicstuff.git) regi>
error: invalid key (newline): submodule.EmuNWAccess-qt
submodule.devices/EmuNWAccess-qt.url

The issue appears to be two submodules with duplicate path fields, and the default Git behavior is more forgiving than whatever Nix is doing. Since submodules should be named after the path they are put into, removing the first duplicate is the correct fix. With this patch, I can build and run QUsb2snes and connect the ALttPR Open Tracker to Retroarch.

Skarsnik commented 3 months ago

I am closing the Pull Request since I did it while removing an unnecessary submodule. Thanks for repporting the issue thou :)

IslandUsurper commented 3 months ago

That works, too! :+1: