Skarsnik / QUsb2snes

A Qt based webserver for usb2snes. Users: go check usb2snes.com
https://skarsnik.github.io/QUsb2snes/
GNU General Public License v3.0
52 stars 34 forks source link

[#79] try to resolve RetroArchHosts first. #82

Closed bmarwell closed 3 years ago

bmarwell commented 3 years ago
Skarsnik commented 3 years ago

Hm, this add blocking code when I am trying to remove most of it now x)

bmarwell commented 3 years ago

Hm, this add blocking code when I am trying to remove most of it now x)

Well, what could be done is to resolve the host name ONCE and then use that the whole time. But I am not good enough at C++ to do this.

Skarsnik commented 3 years ago

Add a comment that QHostInfo::fromName is blocking so I remember to refactor it later when I will make the code fully async x)

bmarwell commented 3 years ago

Done, please re-review @Skarsnik