Skateside / pocket-grimoire

A mobile version of the Blood on the Clocktower grimoire
https://www.pocketgrimoire.co.uk
GNU General Public License v3.0
34 stars 14 forks source link

Positioner layout does not work if Grimoire view is hidden when drawing #84

Closed pedroadame closed 3 months ago

pedroadame commented 7 months ago

When you click "Draw characters" just below selecting a layout, and the grimoire is hidden, the tokens are not drawn in the correct position. They are all piled up in the upper left corner.

Skateside commented 7 months ago

Hi @pedroadame

Would you be able to explain the steps you took to see this bug, and the device you're using, please?

Cheers Skateside

pedroadame commented 7 months ago

Hi @Skateside !

Sure. Just tested both on iOS Safari and Windows Firefox.

  1. Clear cache
  2. Select edition
  3. Make sure "Grimoire" is hidden (i.e view toggled off or collapsed clicking the small arrow)
  4. Click "Select characters" - "Highlight Random" - "Add all"

Expected behavior: The Grimoire view is opened and the character tokens are positioned in the selected layout. Observed behavior: The Grimoire view is opened and all character tokens are piled up on the upper left corner.

Observed workaround:

Cheers!

Skateside commented 6 months ago

Hi @pedroadame

Is this still happening? I've just tried going through the steps that you mentioned on my phone and my PC - I can't reproduce the issue at all.

positioner.webm

Skateside commented 4 months ago

Hi @pedroadame

I've had a play around and I think I've managed to get this bug sorted. Is it still happening for you?

Cheers Skateside

Skateside commented 3 months ago

It's been a month so I'm going to close this issue

pedroadame commented 2 months ago

Hi @Skateside Sorry for the delay. Indeed the issue is fixed, thanks!