search

Skatteetaten / saf-t

Used for publishing of Norwegian SAF-T Schemas, codelists, testfiles etc. See also http://www.skatteetaten.no/saf-t for further documentation and information.
http://www.skatteetaten.no/saf-t
73 stars 111 forks source link

Incorrect type on CID in the schema xsd? #27

Open rodfjell opened 5 years ago

rodfjell commented 5 years ago

Under the object Line under GeneralLedgerEntries it's specified a property for norwegian CID (KID) numbers as follows:

<xs:element name="CID" minOccurs="0" type="xs:nonNegativeInteger">
    <xs:annotation>
        <xs:documentation>The CID number.</xs:documentation>
    </xs:annotation>
</xs:element>

Does this element have the correct type ?

The fact that this element has the type "nonNegativeInteger" becomes an issue on all entities that send invoices with MOD11 checksum on their CIDs. It also becomes an issue when mapping invoices received from suppliers with MOD11 checksum on their CIDs. This is because the checksum digit on MOD11 CID numbers can be the character '-'. CIDs with that checksum digit breaks the XSD validation.

The CID element does not validate the length either. A suggested change would be to add a new simple type to the XSD for this property. Something like this:

<xsd:simpleType name="SAFcidType">
    <xsd:annotation>
        <xsd:documentation>Customer Identification Number used by Norwegian Banks</xsd:documentation>
    </xsd:annotation>
    <xsd:restriction base="xsd:string">
        <xsd:maxLength value="25" />
        <xsd:minLength value="2" />
        <xsd:pattern value="\d+-?" />
    </xsd:restriction>
</xsd:simpleType>

For now the workaround on our end has to be to not map CIDs that contain the checksum digit '-'. But i whould love to hear from Skatteetaten how to deal with this issue.

kjetilko commented 3 years ago

This is also an issue for one of our clients who uses MOD11 to generate CIDs. Our solution is the same as above, to not include the CIDs containing '-'.