search

Skatteetaten / saf-t

Used for publishing of Norwegian SAF-T Schemas, codelists, testfiles etc. See also http://www.skatteetaten.no/saf-t for further documentation and information.
http://www.skatteetaten.no/saf-t
74 stars 111 forks source link

Validation fails due to wrong value in tag <compensation> #34

Open ErikSeverini opened 4 years ago

ErikSeverini commented 4 years ago

We are implementing the SAF-T reporting and run into errors when validation the XML-file via upload at Skatteetaten. The file has passed validation when using the SAF-T XML-validator provided by Skatteetaten (SaftXmlValidator.exe). We have the following error message when uploading:

SAF-T 2020-01.xml The 'urn:StandardAuditFile-Taxation-Financial:NO:Compensation' element is invalid - The value 'TRUE' is invalid according to its datatype 'http://www.w3.org/2001/XMLSchema:boolean' - The string 'TRUE' is not a valid Boolean value. On line number: 1, line position: 1790709.

It seems to be the that does now accept the value TRUE (and later on FALSE). However, the format description for the XML-file has these values for the tag. Here the definition is:

XML Element Description Type Req Rep Example Compensation Indicates the Tax Code is used for compensation xs:Boolean O 0..U true

Thiss is the example provided:

MVA Merverdiavgift 14 Inngående avgift, høy sats 25 NO 1 yes 100 60 MVA Merverdiavgift E1 Purchase of remote services from abroad 25% 0.000 NO 86 TRUE 100.0 Has anyone seen this and was is the action? Any help will be much appriciated - thanks.
TomEkenes commented 4 years ago

Hi Erik We have seen the same some places without solving it yet. Assume related to latest released notes. Have you found solution for this yet or waiting for OSS. BR Tom Ekenes

ErikSeverini commented 4 years ago

Hi Tom, Thanks for your reply.

In fact we tried uploading the file in zipped version. Here no validation is done during upload. Later we receive acceptance from Norwegian Tax. We have then asked Norwegian Tax whether they have an error on their side. Still we have no answer from them.

Meanwhile SAP released note 2886281 addressing - among others - this error. Description for this is "After generating the SAF-T Financial file for Norway, does not have the correct values". I have asked out technical guys to implement this note. Once implemented and tested I will this thread.

BR, Erik Severini

TomEkenes commented 4 years ago

Hi Erik

We are implementing this note now, so I will update you on the result.

Tom Ekenes SAP FI Senior Consultant

Pearl Norge AS Østre Kullerød 2 3241 Sandefjord, Norway Mobil: +47 47 23 11 89 www.pearlconsulting.nohttp://www.pearlconsulting.no/ [Pearl SAP Business partner]

From: ErikSeverini notifications@github.com Sent: fredag 13. mars 2020 15:09 To: Skatteetaten/saf-t saf-t@noreply.github.com Cc: Tom Ekenes tom.ekenes@pearlgroup.no; Comment comment@noreply.github.com Subject: Re: [Skatteetaten/saf-t] Validation fails due to wrong value in tag (#34)

Hi Tom, Thanks for your reply.

In fact we tried uploading the file in zipped version. Here no validation is done during upload. Later we receive acceptance from Norwegian Tax. We have then asked Norwegian Tax whether they have an error on their side. Still we have no answer from them.

Meanwhile SAP released note 2886281 addressing - among others - this error. Description for this is "After generating the SAF-T Financial file for Norway, does not have the correct values". I have asked out technical guys to implement this note. Once implemented and tested I will this thread.

BR, Erik Severini

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Skatteetaten/saf-t/issues/34#issuecomment-598737833, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLOT5AJPEEH2TX2HOQOYDRHI5BBANCNFSM4K3DORKA.

TomEkenes commented 4 years ago

Hi Erik

We have gotten rid of the previous issue, but another new has been introduced: Linje: 1, posisjon: 282257 - The element 'Customer' in namespace 'urn:StandardAuditFile-Taxation-Financial:NO' has invalid child element 'Address' in namespace 'urn:StandardAuditFile-Taxation-Financial:NO'. List of possible elements expected: 'RegistrationNumber, Name' in namespace 'urn:StandardAuditFile-Taxation-Financial:NO'.

So, another waiting game for new note.

BR Tom.

ErikSeverini commented 4 years ago

Hi Tom.

Thanks a lot. I am still waiting for the 2886281 note implemention but it seems that this note resolved the issue. Maybe I will run into the other problem like you, but we will see. I will keep you updated here.

Have a great day! BR, Erik

ErikSeverini commented 4 years ago

Hi Tom.

It tool some time to have the note implemented, but we got it now. We are now at the same level as you. We also got the same error as you. I tried adding the missing tag manually and then the file passes validation. The tag is and it should be between and . I also noted that this tag was there in previous files but has disappeared now .

This is how the modified file looks.

<AuditFile xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="urn:StandardAuditFile-Taxation-Financial:NO" xsi:schemaLocation="urn:StandardAuditFile-Taxation-Financial:NO Norwegian_SAF-T_Financial_Schema_v_1.10.xsd">

1.10 NO 2020-04-06 SAP EU SAP ERP 6.0 2005 Company
Address Lysaker 1366 NO StreetAddress
Did you manage to get any further? BR, Erik
ErikSeverini commented 4 years ago

Oops - something went wrong with the formatting when sending the message. What I mean is that the tag RegistrationNumber should be inserted between tags Company and Name.

Does that make any sense?

TomEkenes commented 4 years ago

Hi Erik

Have you seen the latest notes. It has taken CARE of the problema regarding this. Ps. I would not recommend changing manually. Try keeping SAP versjons and stay with notes if you dont have very special business setup👍🏼

Vennlig hilsen Tom :-). Sendt fra IPhone.

  1. apr. 2020 kl. 12:54 skrev ErikSeverini notifications@github.com:



Oops - something went wrong with the formatting when sending the message. What I mean is that the tag RegistrationNumber should be inserted between tags Company and Name.

Does that make any sense?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Skatteetaten/saf-t/issues/34#issuecomment-609722572, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLOT5NSCFEUHD5KIIPHXDRLGYEXANCNFSM4K3DORKA.

ErikSeverini commented 4 years ago

Hi Tom,

I think we are missing 2 notes. The latest note implemented is 2894075. I see now 2 more notes released after this - 2907856 and 2908369. Are you referring to one of these? We will have them implemented as well.

It seems that the solution is not really complete for Norway as SAP constantly releases new notes.

And obviously we will not modify the files. I just tried it to see if it worked,

BR, Erik

TomEkenes commented 4 years ago

Hi Erik

I didnt have the latest implemented yet either, These are the latest I had:

[cid:image001.png@01D60C24.9515ACF0]

And from this, the customers I have checked have gotten their file validated OK.

The 2907856 should be implemented before 2894075.

SAP is continuously releasing notes here. But my strategy is to stop each customer now when they have validated files. And try to go to SP updates if possible. Would like to see improvement in performance, cause it is still running quite slow.

Of course not companies are alike, so current solution might miss special logic which needs to be implemented in future notes. Handling of reporting currencies if company code currency is not Norwegian as an example. So guess we are stuck with updates for some time still 😊

Tom Ekenes SAP FI Senior Consultant

Pearl Norge AS Østre Kullerød 2 3241 Sandefjord, Norway Mobil: +47 47 23 11 89 www.pearlconsulting.nohttp://www.pearlconsulting.no/ [Pearl SAP Business partner]

From: ErikSeverini notifications@github.com Sent: mandag 6. april 2020 13:17 To: Skatteetaten/saf-t saf-t@noreply.github.com Cc: Tom Ekenes tom.ekenes@pearlgroup.no; Comment comment@noreply.github.com Subject: Re: [Skatteetaten/saf-t] Validation fails due to wrong value in tag (#34)

Hi Tom,

I think we are missing 2 notes. The latest note implemented is 2894075. I see now 2 more notes released after this - 2907856 and 2908369. Are you referring to one of these? We will have them implemented as well.

It seems that the solution is not really complete for Norway as SAP constantly releases new notes.

And obviously we will not modify the files. I just tried it to see if it worked,

BR, Erik

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Skatteetaten/saf-t/issues/34#issuecomment-609732086, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLOT6ADE7WLNJBE4QMQLLRLG237ANCNFSM4K3DORKA.

ErikSeverini commented 4 years ago

Hi Tom,

Sorry to bother you again. We have now implemented the following notes in this sequence:

  1. 2907856
  2. 2894075
  3. 2908369
  4. 2912756 (this note was released on 9th April)

We still have the same error as described above. that there is a RegistrationNumber tag missing between the Company tag and Name tag. So, the notes did not help. Did I understand you corretly that you had the same problem, but the notes did solve this?

Thanks again for your help.

BR, Erik

TomEkenes commented 4 years ago

Hi Erik

We had the same issue at some customers but this note took care of it:

2894075 - SAF-T Norway: Additional Corrections When executing the SAF-T Financial for Norway, after generation of the file, the following issues are detected: After generating the SAF-T Financial file for Norway, for Bussiness Partner as a customer/supplier is empty. After generating the SAF-T Financial file for Norway, Customer/supplier has more than 35 characters and does not match the master data. After generating the SAF-T Financial file for Norway, amount does not consider the currency convertion ratio. After generating the SAF-T Financial file for Norway, you get a validation error: 'List of possible elements expected: 'RegistrationNumber, Name' in namespace'. After generating the SAF-T Financial file for Norway, is not correct.

Are you implementing the notes in the correct order?. SAP has been very strict on that recommendation. You will see the complete list and order in note 2590111

Based on the position 282257 you should be at the customer segment so it is obviously the same error we have seen.

Tom Ekenes SAP FI Senior Consultant

Pearl Norge AS Østre Kullerød 2 3241 Sandefjord, Norway Mobil: +47 47 23 11 89 www.pearlconsulting.nohttp://www.pearlconsulting.no/ [Pearl SAP Business partner]

From: ErikSeverini notifications@github.com Sent: onsdag 15. april 2020 13:50 To: Skatteetaten/saf-t saf-t@noreply.github.com Cc: Tom Ekenes tom.ekenes@pearlgroup.no; Comment comment@noreply.github.com Subject: Re: [Skatteetaten/saf-t] Validation fails due to wrong value in tag (#34)

Hi Tom,

Sorry to bother you again. We have now implemented the following notes in this sequence:

  1. 2907856
  2. 2894075
  3. 2908369
  4. 2912756 (this note was released on 9th April)

We still have the same error as described above. that there is a RegistrationNumber tag missing between the Company tag and Name tag. So, the notes did not help. Did I understand you corretly that you had the same problem, but the notes did solve this?

Thanks again for your help.

BR, Erik

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Skatteetaten/saf-t/issues/34#issuecomment-613990608, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCLOT6QHITIZTAPMMPGVODRMWNOZANCNFSM4K3DORKA.

ErikSeverini commented 4 years ago

Hi Tom.

I just want to give you a short feed back. Note implementation on our side is done by an external team and they confirm that the notes have been implemented in the correct sequence (this is 2907856 before 2894075). But, as 2894075 is addressing exactly the problem, I am not completely sure. However, I am not that technical so I cannot verify myself.

I will update you again when we have news.

Once again, thanks a lot for your help with this.

BR, Erik