fixed release prerequisites

Skatteetaten / terraform-nomad-postgres

Apache License 2.0

8 stars 5 forks source link

fixed release prerequisites #61

Closed pdmthorsrud closed 3 years ago

pdmthorsrud commented 3 years ago

Closes/fixes/resolves issue(s)?

What was added/changed/fixed?

Related issue(s)? [Optional]

Others [Optional]

Checklist (after created PR)

[ ] Added reviewers
[ ] Added assignee(s)
[ ] Added label(s)
[ ] Added to project
[ ] Added to milestone

pdmthorsrud commented 3 years ago

Thinking about it, this might actually be more suitable to include when we have our next release, just so that it can be tested at the same time. WDYT?

claesgill commented 3 years ago

Thinking about it, this might actually be more suitable to include when we have our next release, just so that it can be tested at the same time. WDYT?

I guess it will be tested soon enough in hive. Also, the next release for Postgres is scheduled at 27.11.

But, to be clear. There is no difference in the release? The only thing you have done is to include another package to do the same job, right?

pdmthorsrud commented 3 years ago

Thinking about it, this might actually be more suitable to include when we have our next release, just so that it can be tested at the same time. WDYT?

I guess it will be tested soon enough. The next release is scheduled at 27.11 ;)

But, to be clear. There is no difference in the release? The only thing you have done is to include another package to do the same job, right?

Yep, correct. The only difference is how we get the next_version tag, which now uses a new action. And that action formats it a little different, so I split it to get the correct format :+1: