Skatteetaten / vagrant-hashistack

Vagrant box with the complete hashistack. Use for demo and development.
Apache License 2.0
25 stars 9 forks source link

Add local linting to development workflow #460

Closed fredrikhgrelland closed 3 years ago

fredrikhgrelland commented 3 years ago

Feature description

We have opted to use github/superlinter in order to maintain better code quality in this project. Linting needs to be available to developers before PRs are filed.

Why is it needed?

Currently, linters are used as a QA gate in Pull requests. You will not experience linter warnings/errors before being rejected on the PR. This is bad affordance and must be changed

Suggestion(s)/solution(s) [Optional]

Add make lint to this project. It should run the same linters as GitHub Actions in PR.

Definition of done

Linting can be performed in development and will not fail in PR.

Checklist (after created issue)