Closed wiktor-obrebski closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
fabf6d7
) 98.85% compared to head (7e1537e
) 98.85%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:tada: This PR is included in version 10.6.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
As
fastify-metrics
use internal, specific version ofprom-client
, it sometimes provide situations, where it need to share the promClient instance with external code. Often there much more other sources of metrics that need to be collection, other than fastify requests.Currently, it possible to get internally used
promClient
instance byfastifyApp.metrics.client
, but its not very convinient to use.This PR introduce a way to provide external
promClient
instance to use withfastify-metrics
.-- Additional advantage of this solution is to decrease risk of unintentional usage of 2 different
promClient
instances. It is possible when the project use different version ofprom-client
than thefastify-metrics
use internally.