search

SkeLLLa / fastify-metrics

Prometheus metrics exporter for Fastify
https://savelife.in.ua/en/donate-en/
MIT License
96 stars 33 forks source link

warning message #66

Closed hellower closed 1 year ago

hellower commented 1 year ago

(node:3218427) [FSTDEP012] FastifyDeprecation: Request#context property access is deprecated. Please use "Request#routeConfig" or "Request#routeSchema" instead for accessing Route settings. The "Request#context" will be removed in fastify@5.

my fastify version 4.7.0

SkeLLLa commented 1 year ago

Hi, that's good find. Do you want to make a PR that will handle this issue?

kibertoad commented 1 year ago

I can send a PR tomorrow

kibertoad commented 1 year ago

related: https://github.com/fastify/fastify/issues/4347

kibertoad commented 1 year ago

This can be fixed after fastify releases next version, but it will break TS builds for older 4.x fastify versions. Would you consider that a semver major?

SkeLLLa commented 1 year ago

Yes, it will be major version bump just to be sure that potential breaking changes wouldn't affect current setups.

SkeLLLa commented 1 year ago

Fixed in v10. Thanks @kibertoad.