Custom labels - Githubissues

SkeLLLa / fastify-metrics

Prometheus metrics exporter for Fastify

https://savelife.in.ua/en/donate-en/

MIT License

96 stars 33 forks source link

Custom labels #74

Closed marcopiraccini closed 1 year ago

marcopiraccini commented 1 year ago

Only a predefined set of labels is supported: method, status and route. Sometimes it would be useful to support "custom" labels set, so that we could:

Decorate a request with the info we want to get from the label.
Get the info from the request to populate the custom label.

This would allow to support more fine-grained metrics.

guysegal commented 1 year ago

really +1 for that

SkeLLLa commented 1 year ago

Yes, it might be a good feature, wanna work on PR for this?

guysegal commented 1 year ago

Yeah I'll try (never actively contributed to open source project before 😅)

iamelevich commented 1 year ago

Created PR for this: https://github.com/SkeLLLa/fastify-metrics/pull/80

SkeLLLa commented 1 year ago

Looks like this one is resolved. Feel free to reopen if you need something extra.