search

SkeLLLa / fastify-metrics

Prometheus metrics exporter for Fastify
https://savelife.in.ua/en/donate-en/
MIT License
96 stars 33 forks source link

fix(deprecation): prefer request.routeOptions.method over request.routerMethod #93

Closed juleswritescode closed 10 months ago

juleswritescode commented 10 months ago

Hey Sir!

Awesome library. Thank you for maintaining it!

This PR should fix Issue #90 . It's my first open source contribution, I hope I followed all the rules.

SkeLLLa commented 10 months ago

Amazing, thanks.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de6a03c) 100.00% compared to head (dcaf232) 100.00%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 155 157 +2 Branches 58 60 +2 ========================================= + Hits 155 157 +2 ``` | [Files](https://app.codecov.io/gh/SkeLLLa/fastify-metrics/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex) | Coverage Δ | | |---|---|---| | [src/fastify-metrics.ts](https://app.codecov.io/gh/SkeLLLa/fastify-metrics/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alex#diff-c3JjL2Zhc3RpZnktbWV0cmljcy50cw==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 10.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: