Fix resources, fix image repository, bump chart, fix CI

Skeen / helm-bitwarden_rs

Helm chart for the bitwarden_rs project.

https://github.com/dani-garcia/bitwarden_rs.git

Apache License 2.0

39 stars 19 forks source link

Fix resources, fix image repository, bump chart, fix CI #9

Closed jonkerj closed 3 years ago

jonkerj commented 3 years ago

I've been using your chart (thanks for it!) for a while, and noticed there were some small improvements I've fixed:

The resources were provisioned at pod-level, while (at least on k8s 1.21) it's a property of the container. If I use them with the chart as-is, k8s considers the manifests invalid
The image repository changed from bitwardenrs to vaultwarden
The image tag was a bit behind.

jonkerj commented 3 years ago

I'd really like feedback on my PR. If you do not want it (which is fine of course), please let me know as well. I'd hate to fork a otherwise perfectly working chart :-)

Skeen commented 3 years ago

I'd really like feedback on my PR. If you do not want it (which is fine of course), please let me know as well. I'd hate to fork a otherwise perfectly working chart :-)

Hi,

Sorry about not getting around to triaging this repository. Your changes look good to me, can you figure out the issue with the CI? - If we resolve those I'm happy to merge.

jonkerj commented 3 years ago

I'd really like feedback on my PR. If you do not want it (which is fine of course), please let me know as well. I'd hate to fork a otherwise perfectly working chart :-)

Hi,

Sorry about not getting around to triaging this repository. Your changes look good to me, can you figure out the issue with the CI? - If we resolve those I'm happy to merge.

No prob. I have revamped the CI quite a bit. It follows the reference workflow for (current) CT action, which seems to work fine.