search

Skellington-Closet / skellington

:sparkles::skull::sparkles: The skeleton for your bots
MIT License
64 stars 6 forks source link

Stop being so helpful with the RTM already #44

Closed colestrode closed 7 years ago

colestrode commented 7 years ago

Skellington adds an rtm_close listener to reconnect to the RTM session if there was an error. This is problematic for two reasons:

  1. Sometimes the RTM session can be closed intentionally and we are not checking for that
  2. Botkit has it's own reconnection strategy, this causes the RTM connection to be re-established twice, resulting in double messages/responses.

We should remove the rtm_close handler and defer the reconnection to Botkit.