Skellington-Closet / skellington

:sparkles::skull::sparkles: The skeleton for your bots
MIT License
64 stars 6 forks source link

Update sinon to the latest version 🚀 #59

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 3.0.0 of sinon just got published.

Dependency sinon
Current Version 2.4.1
Type devDependency

The version 3.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of sinon. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes v3.0.0
  • Remove deprecated exports see migration guide
  • Fix #1432: add details around expectations.withArgs behavior to docs (#1501)
  • Fix #1487: incorrect withArgs().returnValue
  • add format.setFormatter
  • Upgrade lolex to 2.1.2
  • Extract fakeXhr, fakeServer and fakeServerWithClock into own module nise and re-import it to keep api the same
Commits

The new version differs by 38 commits.

  • 5daa737 Update docs/changelog.md and set new release id in docs/_config.yml
  • b0ab40d Add release documentation for v3.0.0
  • 18b9d50 3.0.0
  • dd24485 Update Changelog.txt and AUTHORS for new release
  • 3a4688b Merge pull request #1510 from elad-nach/task-update-sinon-migration-guide
  • 387211b updated documentation with a migration guide to sinon@3.0.0
  • 9ee21ad Merge pull request #1506 from mroderick/remove-deprecated-exports
  • e37e1a6 Remove deprecated core exports
  • 3938c12 Merge pull request #1503 from cypress-io/set-formatter
  • fcd2af6 Fix non-run of test-cloud
  • 309dcef Merge pull request #1504 from fatso83/fix-build-and-test-bugs
  • 521a0f7 Simplify scripts using lifecycle events
  • d37ca03 Add proxyquire-universal to headless run
  • a63234a Move failing require statement up the scope
  • a712acb Skip Promise tests on unsupported engines

There are 38 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

colestrode commented 7 years ago

Sinon-chai has a peer dependency on Sinon ^1.4.0 || ^2.1.0. Sinon@3.0.0 is out of ranging and causing the Node 4 build to fail because it's using NPM version 2.15.11, which still enforces peer dependencies. We should wait for sinon-chai to publish a version compatible with sinon 3.0.