Skeltons / pe

0 stars 0 forks source link

Client email with IP as its domain with less than 3 digit in the first field not being accepted. #4

Open Skeltons opened 1 year ago

Skeltons commented 1 year ago

Expected Behavior: IP address as the domain of emails should be accepted

Actual Behavior: Error message is thrown

Steps to reproduce: Add a new client c -cn test333 -e 1234@1.1.1.1 or c -cn test334 -e 1234@16.1.1.1. Error message will be shown

Context: It is entirely possible that the IP address first field be less than 3 digits, especially for Private IP addresses. This would mean that the user would have issues adding clients with such IPs.

image.png

nus-pe-script commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thanks for raising this issue. However, the severity should not be medium and be low instead, as it is unlikely to affect normal operations of the product. Using IP addressses as the email domain appears only in very rare situations and is generally discouraged. We believe this will affect an very small minority of users. Thus we have decided to accept it as a low functionality bug.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]