search

SkepticMystic / breadcrumbs

Add typed-links to your Obsidian notes
https://publish.obsidian.md/breadcrumbs-docs
MIT License
519 stars 35 forks source link

Bug: Incompatible with Obsidian 1.7.2 #567

Open liamcain opened 3 weeks ago

liamcain commented 3 weeks ago

Starting in Obsidian 1.7.2, we are now properly ensuring that plugins load in series. This means that onload is now awaited. The issue is that in Breadcrumbs v3 (the current public version), your onload function awaits waitForCache. From what I can tell, this waits until Dataview has fully loaded. Since we are now awaiting the plugin onload(), this means Dataview won't finish loading until Breadcrumbs finishes loading. This causes a deadlock in Obsidian's loading sequence. This await should not be within the plugin onload. Instead, you should wrap this in onLayoutReady and perform the polling in the background.

daeh commented 2 weeks ago

Likely this issue but I have less insight. But it looks like breadcrumbs is causing Obsidan plugin loading to stall indefinitely.

I do have Dataview installed

CleanShot 2024-09-20 at 16 10 21

mitchmeister commented 2 weeks ago

I have this problem too. Anyone have a workaround

daeh commented 2 weeks ago

If by workaround you mean a way to make breadcumbs work with Obsidian 1.7.2, I don't know. But if you just mean a way to launch obsidian without breadcrumbs, you can disable the extension until there's a fix by deleting its name from .obsidian/community-plugins.json in your vault.

mitchmeister commented 2 weeks ago

thanks 🙏🏻 I disabled the plugin from my iphone & reloaded on my Mac

cvh-obsi commented 2 weeks ago

same problem for me

SkepticMystic commented 2 weeks ago

Thank you for the info, Liam 🙏🏼

For now, there are two workarounds:

  1. Disable Breadcrumbs, as suggested above
  2. Upgrade to Breadcrumbs V4 beta using the BRAT plugin. See here for more info: https://github.com/SkepticMystic/breadcrumbs/blob/master/V4.md

V4 works with Obsidian 1.7.2, but also represents a new way of working with Breadcrumbs. It's not a breaking change in the sense that things should just work when you upgrade. But making changes to your hierarchies is different. Again, see the link for more info. The docs site has been updated to V4, so you can get more acquited with the changes there.

Until I am able to push V4 live into production, V3 will remain broken.

liamcain commented 2 weeks ago

In Obsidian v1.7.3, Obsidian will detect if a plugin is hanging on load and give the option to disable the plugin without needing to manually delete the plugin from the file system.