Sketch-sh / sketch-sh

Sketch.sh - Online Code Editor and ReasonML community
https://sketch.sh
Other
425 stars 37 forks source link

Add ability to create short aliases for URL for cleaner links to notebooks #86

Open kyldvs opened 6 years ago

kyldvs commented 6 years ago

Would be nice if I could set the URL for my notes

Like: https://sketch.sh/s/kyldvs/hello-world

Instead of: https://sketch.sh/s/jrBiLD8KGLXY7UFCejJHnm/BIUwNmD2AEDqkCcwBMg---N4IgRgNg9gxg1gZxALgNqgJYBMUgOIBCYAIgBwBsArgIp4BeA0pXQHYBuBbAjgKJhvkQAGhBYAhgBcxKUHAwscyEDChYApsJBsxEShqUQ1EgAQAPYwF5jAHRAAVABYYEx58YBWlBCbHGJa71sAbmsWAAcAJ3kJAH1vKJYAcwAKUwBKIJAAXyyAXSygA

thangngoc89 commented 6 years ago

@kyldvs thank you for the suggestion. but I'm not sure I like this idea. you can drop everything outside

/s/nodeId/__drop_everything_here

the reason for that part is to ensure longevity of the sketch

I documented it here https://github.com/Sketch-sh/sketch-sh/issues/49

kyldvs commented 6 years ago

Ah, it's not obvious that you can drop the last part! That solves most of this issue.

I think it could still be a nice feature, but if linking by just the note-id works, this is definitely much lower pri than other work that could be done.

I'll close this out for now.

thangngoc89 commented 6 years ago

The intention was you should share the whole url, So I made it not obvious ;)

kyldvs commented 6 years ago

Fair enough, a "copy short url" or something might be a good trade off to make this discoverable, if you choose to. I think having a nice clean URL is something that can be valuable in certain situations (for example you want to link here but can't change the text displayed due to the medium you are communicating in)

thangngoc89 commented 6 years ago

that's reasonable to me. so a share link with option to include or exclude the encoded data. with explanations for the trade-offs