UI::HtmlDialog::STYLE_WINDOW description

SketchUp / api-issue-tracker

Public issue tracker for the SketchUp and LayOut's APIs

https://developer.sketchup.com/

38 stars 10 forks source link

UI::HtmlDialog::STYLE_WINDOW description #269

Open MSP-Greg opened 5 years ago

MSP-Greg commented 5 years ago

The doc's for UI::HtmlDialog.new show a description for the UI::HtmlDialog::STYLE_WINDOW constant as:

"HtmlDialog can go behind SketchUp and doesn't disappear when SketchUp looses focus."

Maybe this could be changed from `when SketchUp looses focus.' to 'when SketchUp is minimized.' ? If not, I think it should be 'loses', not 'looses'...

Also, YARD can attach comments to constants. It would be nice if the constants showed the descriptions, although they would be repeated...

See the code

thomthom commented 5 years ago

Maybe this could be changed from `when SketchUp looses focus.' to 'when SketchUp is minimized.' ?

This might relate to OSX, where child windows disappear when the parent windows is not in focus. ...might even be Windows... I need to refresh my memory.

Also, YARD can attach comments to constants. It would be nice if the constants showed the descriptions, although they would be repeated...

We got nearly 200 constants in the API, none of them was ever documented with its own comment. It's something I've been wanting to clean up.

MSP-Greg commented 5 years ago

Thom,

Thanks, obviously not a big deal. I checked on Windows 10, and 'child windows disappear when the parent windows is not in focus' does not occur.

Also, where as a default HTMLDialog does not create a taskbar item, a STYLE_WINDOW dialog adds one. It's grouped within the main Sketchup icon, but appears as an addition item. I think that made sense...

We've got nearly 200 constants in the AP

Yeah, not a trivial amount. I guess I'm used to seeing constants doc'd. So, at the wrong time, I may find that irritating. Others may not have the issue...