search

SketchUp / api-issue-tracker

Public issue tracker for the SketchUp and LayOut's APIs
https://developer.sketchup.com/
38 stars 10 forks source link

View#write_image and Overlay #904

Open Fredosixx opened 1 year ago

Fredosixx commented 1 year ago

First, it is unclear whether view#wite_image should or not draw the overlay drawings. Currently it does...

Second, in any case it does not draw it correctly and seems to pave the image file with a tiling of the overlay drawings

Scene_7942027

The minimum is to get clarification about this.

DanRathbun commented 1 year ago

I think this has been reported and perhaps already assigned a Jira issue.

My opinion is that it can be useful if it works correctly, but the [View#write_image]() method should get an additional Boolean :overlays options in the argument hash so coders can choose to include them, and so that current code is not affected. (Ie, the option should default to false, if not given so that extensions in the wild do not see them.)

It might be interesting if somehow coders could choose a specific overlay to include in the output whilst suppressing all others. I suppose this can be done now by iterating the overlays manager and switching those off that are not desired in the output.

Fredosixx commented 1 year ago

Actually the bug is the tiling. Disabling or enabling overlay works anyway, until we have it in the options.

Sent from Outlook for iOShttps://aka.ms/o0ukef

From: DanRathbun @.> Sent: Tuesday, June 6, 2023 2:04:27 PM To: SketchUp/api-issue-tracker @.> Cc: Fredosixx @.>; Author @.> Subject: Re: [SketchUp/api-issue-tracker] View#write_image and Overlay (Issue #904)

I think this has been reported and perhaps already assigned a Jira issue.

My opinion is that it can be useful if it works correctly, but the View#write_image method should get an additional Boolean :overlays options in the argument hash so coders can choose to include them, and so that current code is not affected. (Ie, the option should default to false, if not given so that extensions in the wild do not see them.)

It might be interesting if somehow coders could choose a specific overlay to include in the output whilst suppressing all others. I suppose this can be done now by iterating the overlays manager and switching those off that are not desired in the output.

— Reply to this email directly, view it on GitHubhttps://github.com/SketchUp/api-issue-tracker/issues/904#issuecomment-1578632738, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANYUELI7DFVH3UFDC42E3QDXJ4MEXANCNFSM6AAAAAAY4HPBII. You are receiving this because you authored the thread.Message ID: @.***>

thomthom commented 1 year ago

It wasn't intended that view.write_image would include Overlays. This is internally logged as a bug.

DanRathbun commented 1 year ago

Yes, but again it could be beneficial. Fredo gives an example in the 1st post.

Other uses:

@Fredosixx What platform, resolution and display scaling are you seeing this on ?

Fredosixx commented 1 year ago

Windows 10. Resolution set at the size of the viewport or multiple. But Tiling seems to follow its own logic.

Sent from Outlook for iOShttps://aka.ms/o0ukef

From: DanRathbun @.> Sent: Tuesday, June 6, 2023 4:10:32 PM To: SketchUp/api-issue-tracker @.> Cc: Fredosixx @.>; Mention @.> Subject: Re: [SketchUp/api-issue-tracker] View#write_image and Overlay (Issue #904)

Yes, but again it could be beneficial. Fredo gives an example in the 1st post.

Other uses:

@Fredosixxhttps://github.com/Fredosixx What platform, resolution and display scaling are you seeing this on ?

— Reply to this email directly, view it on GitHubhttps://github.com/SketchUp/api-issue-tracker/issues/904#issuecomment-1578842538, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANYUELP4LPQKLAIJHQ3G55TXJ425RANCNFSM6AAAAAAY4HPBII. You are receiving this because you were mentioned.Message ID: @.***>

sketchup[bot] commented 1 year ago

Logged as: SKEXT-3718

dphdave commented 1 year ago

Another use case I am currently looking at is compiling a report of production information, where various overlays are used to show different properties of the components of a building, then images of the building with the various overlays enabled are used to assist fabrication and assembly.