SketchUp / ruby-api-docs

SketchUp Ruby API Documentation
18 stars 9 forks source link

iphone #19

Closed alfu32 closed 7 years ago

alfu32 commented 7 years ago

if this is the source for http://ruby.sketchup.com/

screen does not scroll on iphone. it is completely unusable on an iphone. tried in safari and chrome.

thomthom commented 7 years ago

Yes, we have an internal issue logged for this. The stylesheet activated for small monitors is currently bugged.

This is the repo for the generated source. The actual YARD template that generates it is located in another repo: https://github.com/SketchUp/sketchup-yard-template

alfu32 commented 7 years ago

quick fix

in style.css line 57

@media (max-width: 920px) {
  .nav_wrap { display: none; }
}

modify

@media (max-width: 920px) {
  .nav_wrap { display: none; }
  #main { 
    /*height: 100%; not necessary for this test but present in the  @media (min-width: 920px) */
    /* overflow: auto; not necessary for this test but present in the  @media (min-width: 920px) */
    /* at least this */
    overflow-y: scroll;
  }
}

just copy the rule

#main { height: 100%; overflow: auto; }

from line 64 inside

@media (max-width: 920px) {

tested in chrome, dev tools open , activate responsive desgn, resize device width to less than 920px,or select iphone6 before : no body scrolling, no menu-icon in view, if menu open, menu scrolls after : body scrolls , menu icon in view, menu scrolls;

alfu32 commented 7 years ago

and i belive the issue is in this repo (if any of the static resources are not updated upon build)

sketchup-yard-template-master/su-template/default/layout/html/setup.rb:
   15  end
   16  
   17: def stylesheets
   18    %w(css/style.css css/sketchup.css css/rubyapi.css)
   19  end

css/style.css : i don't believe it is generated .... maybe it is copied from some internal folder ....

thomthom commented 7 years ago

style.css is copied from the YARD default template: https://github.com/lsegal/yard/tree/master/templates/default/fulldoc/html/css

The SketchUp Ruby API docs are mostly just the standard YARD template with some color adjustments and the custom header.

alfu32 commented 7 years ago

so the issue is in their yard not yours.

thomthom commented 7 years ago

The scrolling was due to the header customisation we made. I pushed your fix today.

jimfoltz commented 7 years ago

Works great!