Tool Nav is broken

[stoutb77]

This version (2013) tries to load the tools under the Draw->shapes menu. However for 2014, a shapes menu has been added an it contains the rectangle, circle and polygon tools. As a result the extension features are not showing up in the 2014 UI.

We should think about how to relocate them. Perhaps Draw-> 3D shapes-> .... ?

[thomthom]

Lets see what fixes we get when we public and merge with that user.

[johnwmcc]

I'm just about to make a Pull Request to you with extensions to sketchup_shapes.rb, and I found and fixed this issue by renaming it (as you suggest) as 3D Shapes.

I'm trying to work out just HOW to make a pull request. I've found the GitHub help topic, but not yet worked out how to do it as they describe.

John McClenahan

[thomthom]

When you view your repository on GitHub you have the Pull Requets link on the right hand side:

From there you get a new page with an overview of all active pull requests. Click the "New pull request" button.

Note that you need to submit your local changes from your computer back to your fork on GitHub.

[johnwmcc]

Thanks. I’ve got as far as finding the New Pull Request, but am having some trouble getting my changes uploaded and recognised on my own fork – it is still reporting (when I try a Compare Fork) that my code is identical to the original Sketchup code!

I’ll get it sorted in a day or two – I hope for help from a friend tomorrow who is experienced in open source coding (he works on the FlightGear flight simulator). This is my first ever attempt to join an open source coding project.

Best wishes

John McC

From: Thomas Thomassen [mailto:notifications@github.com] Sent: 29 January 2014 22:18 To: SketchUp/sketchup-shapes Cc: johnwmcc Subject: Re: [sketchup-shapes] Tool Nav is broken (#1)

When you view your repository on GitHub you have the Pull Requets link on the right hand side: https://f.cloud.github.com/assets/192418/2034921/c30d62cc-8932-11e3-8708-f1730b74b817.png 2014-01-29_23h14_07

From there you get a new page with an overview of all active pull requests. Click the "New pull request" button. https://f.cloud.github.com/assets/192418/2034923/c63690a4-8932-11e3-962b-61bec0ac17c0.png 2014-01-29_23h14_24

Note that you need to submit your local changes from your computer back to your fork on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/SketchUp/sketchup-shapes/issues/1#issuecomment-33637972 . https://github.com/notifications/beacon/6536597__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjU2NjcwNCwiZGF0YSI6eyJpZCI6MjM5NzQ5MzN9fQ==--c253ea1ef4d74644d5e2ac882ea77b3550985043.gif

[thomthom]

What Git client are you using? Sourcetree?

[johnwmcc]

Yes, SourceTree

J On 30 Jan 2014 01:14, "Thomas Thomassen" notifications@github.com wrote:

What Git client are you using? Sourcetree?

Reply to this email directly or view it on GitHubhttps://github.com/SketchUp/sketchup-shapes/issues/1#issuecomment-33651182 .

[thomthom]

If you cloned your local repo from your fork via SourceTree then your default remote should be already set up.

Git can be daunting when you first encounter it, but trust me, it gets better quickly and you'll love it eventually.