DanRathbun
commented
8 years ago I'm unclear whether, and if so how, you want to update the Community Extension version to correspond.
Generally, pull requests need to be made against specific open issues. One request per issue, and only changes to satisfy that one issue, so it can be easily tested and then merged and closed.
I'd have to guess your code base is now too much diverged from the main trunk. So I'd vote it just remain separate as your edition of the Shapes extension, under your own module.
Eventually, someone else can cut and paste snippets into other pull requests, one at a time, to get the open issues closed and merged properly into the Community edition.
I am also not convinced the 3D Shapes edition should be extended with a bunch of Wireframe shapes. (Like Thomas I expect them to be solids.) Might be better if wireframe shapes were a separate extension, and on their own sub-menu of the Draw menu ?
I've now updated the SketchUcation Plugin Store version of this plugin to include three new shapes - Helix, Helical Ramp, and Helical Ramp with Sides. I've made a couple of other minor updates - to add missing validation for the number of sides or segments to draw in Tube, Torus and Pyramid shapes, and to add a centre point on key faces in the inserted shapes, to aid placement and Move/Copy operations.
I've also changed the code, following an extremely helpful suggestion and sample code from Jim Foltz, to change from inserting each shape as a Group at the world origin, to creating a component definition, and allowing the user to place it at any pickable point using the API function _Sketchup.active_model.placecomponent.
I'm unclear whether, and if so how, you want to update the Community Extension version to correspond.
I can post updated versions of all the relevant files on GitHub, with the names and internally distinct Module names I adopted to keep the two versions separate - jwm_shapes.rb instead of shapes.rb, an overall module name JWM instead of Community Extensions, and a sub-module name of JWMShapes instead of Shapes, and the amended code to insert components.
Alternatively, and much simpler for me, I can email a copy of the jwm_shapes2.5.rbz file to you for you to decide how best to rename the contents to keep the two versions distinct, should you wish to update the SU Shapes version to add the additional functionality. It also includes updated documentation and changelog.
Please let me know how to proceed from here.